Skip to content

Conversation

@nathanielerowe
Copy link
Contributor

Small bug fix for VP873 devices. Might be some other weirdness going on as well though.

fix bundle fetching
@nathanielerowe nathanielerowe added the bugfix Addresses one or more bugs label Sep 22, 2025
@nathanielerowe nathanielerowe marked this pull request as ready for review October 22, 2025 03:44
@kjplows kjplows moved this from PR in progress to Open pull requests in SBN software development Oct 22, 2025
Copy link
Contributor

@maxdubnowski maxdubnowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am shocked this didn't cause errors before!?

@linyan-w linyan-w moved this to Expected for validation II in SBND 2025 Fall Production - Validation Oct 27, 2025
@linyan-w linyan-w moved this from Expected for validation II to Waiting on Reviewer in SBND 2025 Fall Production - Validation Nov 3, 2025
@linyan-w linyan-w moved this from Waiting on Reviewer to Reviewer Approved in SBND 2025 Fall Production - Validation Nov 3, 2025
@kjplows kjplows moved this from Open pull requests to Testing in SBN software development Nov 4, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Nov 4, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Nov 4, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Nov 4, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Nov 4, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Nov 4, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Nov 4, 2025
@kjplows
Copy link
Contributor

kjplows commented Nov 4, 2025

trigger build ci_ref=v10_06_02 LArSoft/larsoft@LARSOFT_SUITE_v10_06_00_02 LArSoft/larwirecell@LARSOFT_SUITE_v10_06_00_02 LArSoft/lar*@LARSOFT_SUITE_v10_06_00 SBNSoftware/sbndcode@v10_06_00_05 SBNSoftware/sbn*@release/SBN2025A

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@nathanielerowe
Copy link
Contributor Author

This has been updated to handle some other issues:

  1. Fix TimeWindow to force more reasonably sized queries.
  2. Change default values to something more noticeable.
  3. Bump the epsilon up a bit for the offsets.
  4. Remove a duplicate fcl file.

@kjplows
Copy link
Contributor

kjplows commented Nov 5, 2025

Thanks! Re-running CI

@FNALbuild
Copy link

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@kjplows kjplows moved this from Testing to To merge in SBN software development Nov 5, 2025
@kjplows kjplows merged commit 6e60015 into release/SBN2025A Nov 5, 2025
@github-project-automation github-project-automation bot moved this from To merge to Done in SBN software development Nov 5, 2025
@kjplows kjplows moved this from Done to Recently done in SBN software development Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Addresses one or more bugs

Projects

Status: Recently done
Status: Reviewer Approved

Development

Successfully merging this pull request may close these issues.

5 participants